> We doesn’t come to an agreement that API should be changed. > We should discuss the design of the Metric API and your proposals for it in > another thread. > Please, avoid arguments like «this API will be 100% changed» in this > discussion.
I just explain why this item is acceptable to me. I don't discuss how exactly something will changed, etc. On Thu, Jan 30, 2020 at 2:34 PM Nikolay Izhikov <nizhi...@apache.org> wrote: > > Hello. > > > 2. Add @IgniteExperimetnal to new API (because... see item. 1 > > +1 > > > 1. Remove @Deprecated from old API (because it strange to have one > > deprecated API and second experimental API) > > -1 > > I propose to update deprecation message and provide metric name for each > deprecated method. > > > @deprecated Use {@link JmxMetricExporterSPI} instead. Name of the metric > > «io.dataregion.pageCount» > > Andrey. > > We doesn’t come to an agreement that API should be changed. > We should discuss the design of the Metric API and your proposals for it in > another thread. > > Please, avoid arguments like «this API will be 100% changed» in this > discussion. > > > 30 янв. 2020 г., в 14:21, Andrey Gura <ag...@apache.org> написал(а): > > > > From my point of view we still don't have consensus. > > > > I think we should do at least the following: > > > > 1. Remove @Deprecated from old API (because it strange to have one > > deprecated API and second experimental API) > > 2. Add @IgniteExperimetnal to new API (because... see item. 1) > > 3. Do not merge IGNITE-12553 (because it adds new public interface > > that 100% will be changed) > > > > ideally we should also: > > > > 4. Add metrics that available only via new API to the old API (because > > otherwise we force user interact with both API's) > > > > On Thu, Jan 30, 2020 at 12:35 PM Alexey Goncharuk > > <alexey.goncha...@gmail.com> wrote: > >> > >> Folks, > >> > >> I tried to re-read the whole thread and honestly got lost at the end :) Do > >> we have a consensus (if yes, what are the steps?) or should we have a call > >> as Maxim suggested? > >> > >> I think it is in our best interest to get this agreed upon fast to release > >> AI 2.8 soon. >