Things are starting to look healthier now. I went through the broken-build JIRAs and downgraded some of the infrequent infrastructure issues to critical so we have a clearer idea of what's actually breaking the build now versus what's an occasional infra issue: https://issues.apache.org/jira/issues/?jql=project%20%3D%20IMPALA%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20labels%20%3D%20broken-build%20ORDER%20BY%20priority%20DESC
I'd like to see the fixes for these three issues go in: https://issues.apache.org/jira/browse/IMPALA-7101 https://issues.apache.org/jira/browse/IMPALA-6956 https://issues.apache.org/jira/browse/IMPALA-7008 We still need to fix any flaky infrastructure issues but that should be able to proceed in parallel with other things. On Fri, Jun 1, 2018 at 11:18 AM, Thomas Tauber-Marshall < [email protected]> wrote: > So while its definitely better, there are still a large number of failing > builds. We've been hit by at least: IMPALA-6642 > <https://issues.apache.org/jira/browse/IMPALA-6642>, IMPALA-6956 > <https://issues.apache.org/jira/browse/IMPALA-6956>, IMPALA-7101 > <https://issues.apache.org/jira/browse/IMPALA-7101> and IMPALA-3040 > <https://issues.apache.org/jira/browse/IMPALA-3040> > all within the last day, along with some mysterious crashes that I haven't > filed anything for with Apache yet as there's very little info about what's > actually going on. There are still multiple builds that haven't been green > in over a month. > <https://issues.apache.org/jira/browse/IMPALA-6642> > > Of course, if we hold commits for too long, there's a danger that when we > open things back up a bunch of changes will all land at the same time and > destabilize the builds again, putting back in the same situation. So, I > would say at a minimum that any changes that are relatively minor and low > risk can go in now. > > My preference would be to hold off on major changes until we have more > stability. > > On Fri, Jun 1, 2018 at 10:30 AM Lars Volker <[email protected]> wrote: > > > Hi Thomas, > > > > Can you give an update on where we are with the builds? > > > > We currently have ~15 changes with a +2: > > > > https://gerrit.cloudera.org/#/q/status:open+project:Impala- > ASF+branch:master+label:Code-Review%253D2 > > > > Thanks, Lars > > > > On Fri, May 25, 2018 at 5:20 PM, Henry Robinson <[email protected]> > wrote: > > > > > +1 - thanks for worrying about build health. > > > > > > On 25 May 2018 at 17:18, Jim Apple <[email protected]> wrote: > > > > > > > Sounds good to me. Thanks for taking ownership! > > > > > > > > On Fri, May 25, 2018 at 5:10 PM Thomas Tauber-Marshall < > > > > [email protected]> wrote: > > > > > > > > > Hey Impala community, > > > > > > > > > > There seems to have been an unusually large number of flaky or > broken > > > > tests > > > > > < > > > > > https://issues.apache.org/jira/browse/IMPALA-7073?jql= > > > > project%20%3D%20IMPALA%20AND%20status%20in%20(Open%2C%20% > > > > 22In%20Progress%22%2C%20Reopened)%20AND%20labels% > > > > 20in%20(flaky%2C%20broken-build) > > > > > > > > > > > cropping up in the last few weeks. I'd like to suggest that we hold > > off > > > > on > > > > > merging new changes that aren't related to fixing those testing > > issues > > > > for > > > > > at least a few days until things become more stable. > > > > > > > > > > Does anyone have any objections? If not, I'll send out another > email > > > when > > > > > more of the issues have been addressed. > > > > > > > > > > Thanks, > > > > > Thomas Tauber-Marshall > > > > > > > > > > > > > > >
