Juan Yu has posted comments on this change. Change subject: IMPALA-1939: Impalad should not require a co-located DataNode ......................................................................
Patch Set 5: (2 comments) Could you also rebase? http://gerrit.cloudera.org:8080/#/c/1121/5/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: Line 683: if (!((fs instanceof DistributedFileSystem) || (fs instanceof S3AFileSystem) || Do we currently support all s3 filesystem, or just s3a? We also support LocalFilesystem now, right? Line 684: (fs instanceof NativeS3FileSystem) || (fs instanceof S3FileSystem))) { wrong indentation here and below. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
