Dan Hecht has posted comments on this change. Change subject: IMPALA-1939: Impalad should not require a co-located DataNode ......................................................................
Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/1121/6//COMMIT_MSG Commit Message: Line 11: required only if a datanode co-exists This comment doesn't match the code change. And this looks more like IMPALA-1850 more than 1939, no? http://gerrit.cloudera.org:8080/#/c/1121/6/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: Line 34: import org.apache.hadoop.fs.s3native.NativeS3FileSystem; don't import the ones you don't need Line 694: " is not supported"); indentation is off. also the parenthesis around the whole thing are not needed. http://gerrit.cloudera.org:8080/#/c/1121/6/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 14: class TestMultipleFilesystems(ImpalaTestSuite): I think this means we completely loose coverage of this test. we need to find a different way to run it. http://gerrit.cloudera.org:8080/#/c/1121/6/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 15: @SkipIfS3.insert this is an awful lot of coverage to lose. can we fix up the tests? or at least make this skip more fine-grained? Line 126: @SkipIfS3.insert same comment. and why is it that more of this test now needs to be skipped? -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
