Juan Yu has posted comments on this change. Change subject: IMPALA-1939: Impalad should not require a co-located DataNode ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/1121/6/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: Line 34: import org.apache.hadoop.fs.s3native.NativeS3FileSystem; then we don't need to import the other two either. Line 690: return ("Currently configured default file system:" + still wrong indentation. 4 spaces for continuous line 2 spaces for new line inside {} http://gerrit.cloudera.org:8080/#/c/1121/6/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 149 are you sure this one works on S3? Looks like one test will do "insert overwrite" -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
