Alex Behm has posted comments on this change. Change subject: Reduce size of cross-compiled IR ......................................................................
Patch Set 1: (1 comment) Looks reasonable to me. Are there more places that could benefit from the inline annotation or is this a complete set? If it's not yet complete, it would be good to track what has been done and where we could continue. http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: Line 65: COMMAND ${LLVM_OPT_EXECUTABLE} ${LLVM_OPT_IR_FLAGS} < ${IR_SSE_TMP_OUTPUT_FILE} > ${IR_SSE_OUTPUT_FILE} long lines -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
