Dan Hecht has posted comments on this change. Change subject: Reduce size of cross-compiled IR ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/common/status.h File be/src/common/status.h: Line 156: inline IR_ALWAYS_INLINE ~Status() { > is 'inline' needed here in order for this to be inlined (into non-cross com Yes, Michael added these inlines when he was speeding up Status. Apparently GCC was not always inlining them otherwise. For things that we want inlined no matter what in both non-IR and IR, we could define an ALWAYS_INLINE macro that expands to the right things in both modes. -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
