Marcel Kornacker has posted comments on this change. Change subject: Reduce size of cross-compiled IR ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/common/status.h File be/src/common/status.h: Line 156: inline IR_ALWAYS_INLINE ~Status() { is 'inline' needed here in order for this to be inlined (into non-cross compiled code)? marking all functions that are defined in the .h file as 'inline IR_ALWAYS_INLINE' is tedious and noisy. is there an alternative? http://gerrit.cloudera.org:8080/#/c/2464/1/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 131: int IR_ALWAYS_INLINE level() const { return level_; } > It does do the inlining in the runtime -O2 optimisation, but it was difficu is there some custom inlining pass we could write that would inline everything that is below a fixed number of instructions? (or is that what the hints are supposed to do already? and if so, why is that not working?) -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
