Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3132: link ImpalaUdf first in UDF tests ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2471/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 343: # definitions to be linked instead of subsequent non-test definitions. reference jira and add the gist of your commit message here. http://gerrit.cloudera.org:8080/#/c/2471/1/be/src/exprs/aggregate-functions-test.cc File be/src/exprs/aggregate-functions-test.cc: Line 168: InitCommonRuntime(argc, argv, false, TestInfo::BE_TEST); it looks like we have now increased our dependency on things that are unrelated to this test. why is that necessary? also, you changed the order. is the ordering immaterial? -- To view, visit http://gerrit.cloudera.org:8080/2471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I619c9e708794aaf1138bdc0087fbe82539c0817e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
