Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3132: link ImpalaUdf first in UDF tests ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2471/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 343: # definitions to be linked instead of subsequent non-test definitions. > reference jira and add the gist of your commit message here. Done http://gerrit.cloudera.org:8080/#/c/2471/1/be/src/exprs/aggregate-functions-test.cc File be/src/exprs/aggregate-functions-test.cc: Line 168: InitCommonRuntime(argc, argv, false, TestInfo::BE_TEST); > it looks like we have now increased our dependency on things that are unrel Maybe not necessary, but this is currently the canonical way to turn off stdout/stderr redirection in tests. Given that we already link everything into every test, it seemed better to err on the side of consistency, but I could add back the two removed lines and also add TestInfo::Init(BE_TEST) to achieve the same effect. I like the idea of having a common function to call to do all these things though, I think to fix the dependencies it would be better to strip down this function/compilation unit rather than have each test duplicate the parts it needs. I switched the order because most other tests put them in this order, but looking at more files I see both orderings. I don't think it makes a difference. -- To view, visit http://gerrit.cloudera.org:8080/2471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I619c9e708794aaf1138bdc0087fbe82539c0817e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
