Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3132: link ImpalaUdf first in UDF tests ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2471/2/be/src/exprs/aggregate-functions-test.cc File be/src/exprs/aggregate-functions-test.cc: Line 168: InitCommonRuntime(argc, argv, false, TestInfo::BE_TEST); > Would you mind adding a brief comment in exprs/CMakeLists.txt mentioning th I added a new ADD_UDF_TEST cmake function in be/CMakeLists.txt instead, since udf/CMakeLists.txt uses the same logic. This more closely follows the ADD_BE_TEST logic too. I also got rid of UDF_TEST_LINK_LIBS and instead add the ImpalaUdf link lib directly in ADD_UDF_TEST, because I think we have too many scattered cmake variables, but I can add it back if anyone disagrees. -- To view, visit http://gerrit.cloudera.org:8080/2471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I619c9e708794aaf1138bdc0087fbe82539c0817e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
