Internal Jenkins has submitted this change and it was merged.

Change subject: Reduce size of cross-compiled IR
......................................................................


Reduce size of cross-compiled IR

Disable the instnamer pass to reduce bitcode file size. Enable
inlining with a low threshold to inline many trivial functions in
the cross-compiled IR (e.g. scoped_ptr accessor functions).
Add additional IR_ALWAYS_INLINE annotations to trivial functions
that are called on hot paths.

This means that the functions will be inlined at compile time and
codegen has to do less work at runtime.

The IR module size is reduced from ~1.9MB to ~1.4MB with this
change and codegen time is slightly reduced. The number of functions is
reduced from 5698 to 3883.

Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446
Reviewed-on: http://gerrit.cloudera.org:8080/2464
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Internal Jenkins
---
M be/CMakeLists.txt
M be/src/codegen/CMakeLists.txt
M be/src/common/compiler-util.h
M be/src/common/status.h
M be/src/exec/hash-table.h
M be/src/exec/partitioned-hash-join-node.h
M be/src/runtime/row-batch.h
M be/src/runtime/tuple-row.h
8 files changed, 58 insertions(+), 40 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/2464
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to