Skye Wanderman-Milne has posted comments on this change. Change subject: Reduce size of cross-compiled IR ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2464/2/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 131: int IR_ALWAYS_INLINE level() const { return level_; } > Done. It's a little confusing in this file since some things should be IR_A Yea, I think it's least confusing if you use IR_ALWAYS_INLINE in the cases where it's necessary for codegen and ALWAYS_INLINE when it's good for perf. -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
