Tim Armstrong has posted comments on this change. Change subject: Reduce size of cross-compiled IR ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2464/2/be/CMakeLists.txt File be/CMakeLists.txt: Line 137: set(LLVM_OPT_IR_FLAGS "-O1" "-inline" "-inlinehint-threshold=10" "-inline-threshold=10") > Do you mean to include O1? Good point, it's not really necessary. http://gerrit.cloudera.org:8080/#/c/2464/2/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: Line 59: # unnamed instr. This makes the IR verifiable and more readable. > It's hard to say for sure but looking at LLVM's source, I don't see why you Done. The idea that Clang would emit non-verifiable IR doesn't make any sense to me, and this seems to work ok, so I think we're ok. http://gerrit.cloudera.org:8080/#/c/2464/2/be/src/exec/hash-table.h File be/src/exec/hash-table.h: Line 131: int IR_ALWAYS_INLINE level() const { return level_; } > ALWAYS_INLINE? Done. It's a little confusing in this file since some things should be IR_ALWAYS_INLINE (big functions that need to be inlined for some substitution to work). http://gerrit.cloudera.org:8080/#/c/2464/2/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: Line 439: BufferedTupleStream* IR_ALWAYS_INLINE build_rows() { return build_rows_; } > ALWAYS_INLINE for these? Done -- To view, visit http://gerrit.cloudera.org:8080/2464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea04ad2e4b365564ee71082657262485d3a85446 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
