Michael Ho has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor ......................................................................
Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/2203/15/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: Line 98: Can happen if Prepare() failed. > one way to interpret this comment is that a resource leak can happen if Pre Good idea to do the DCHECK regardless of whether batch_ is NULL or not. Will have to do more comprehensive testing to verify things are fine. http://gerrit.cloudera.org:8080/#/c/2203/15/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 165: static_cast<int64_t> > this cast shouldn't be needed - converting from smaller to larger type just Removed. -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 15 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
