Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/13/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 198: RETURN_IF_ERROR(parse_status_); > as we discussed, using parse_status_ here is a step backwards -- now this c Ack didn't see your previous discussions, and this is what I suggested earlier. I thought this was consistent with existing behavior, instead of setting parse_status_ to whatever the query status is in the parquet scanner. I'm pretty sure all scanners use parse_status_ to store an error in the scanner itself, and we do this in HdfsScanner::GetCollectionMemory(). I'm fine either way though. -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
