Michael Ho has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/2203/14/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: Line 95: DCHECK(prepared_ == (batch_ != NULL)); > this doesn't look true -- what if StartNewRowBatch() takes the mem limit ex That's true. We can only rely on if(batch_ != NULL) and DCHECK(batch_ != NULL|| !prepared_). -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 14 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
