David Ribeiro Alves has posted comments on this change. Change subject: Review Only: Kudu Impala integration ......................................................................
Patch Set 8: Note that I rebased the on the feature kudu side since the last patch and that I found 4 additional bugs that are addressed in this rev: - Somehow we lost support for ignoring casing in the "kudu.key_columns" field of the table properties (maybe something changed on trunk, not sure how we ever had it). Fixed in KuduUtil.java. - DROP DATABASE ... CASCADE, a feature added to trunk since we forked, doesn't work on kudu. This makes builds fail the second time they are ran. Created a jira for this, IMPALA-3178, and basically brought back the old test-only code that used to delete a database table by table, before we had CASCADE. - Alter TBLPROPERTIES is not working on Kudu either, in spite of it working for other tables. Created IMPALA-3179 for this and commented out the test (with a comment pointing to the jira). - Updates in the frontend were not validating the source expressions against the target column. Again something might have changed or we were ignoring a test error, not sure how we ever had it. Fixed this by performing the same kind of validation/cast we do for inserts. Left a TODO to consolidate with the checking that is performed in InsertStmt. Finally changed all the TODOs that were created during this process to be TODO(kudu-merge) so that we can pick them up after the merge. -- To view, visit http://gerrit.cloudera.org:8080/1403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I239314acbc8434ef673a3a59d2a82a0338ea5876 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
