Dan Hecht has posted comments on this change. Change subject: Review Only: Kudu Impala integration ......................................................................
Patch Set 8: Code-Review+1 (1 comment) BE looks okay but would be good if you could address that one nit. http://gerrit.cloudera.org:8080/#/c/1403/8/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 218: num_rows = cur_kudu_batch_.NumRows(); nit: hoist the num_rows initialization above the for stmt, and then try to fit the for clause on one line. -- To view, visit http://gerrit.cloudera.org:8080/1403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I239314acbc8434ef673a3a59d2a82a0338ea5876 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
