David Ribeiro Alves has posted comments on this change. Change subject: Review Only: Kudu Impala integration ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/1403/8/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 218: num_rows = cur_kudu_batch_.NumRows(); > nit: hoist the num_rows initialization above the for stmt, and then try to Done http://gerrit.cloudera.org:8080/#/c/1403/8/fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java File fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java: Line 23: * Empty implementation for the DdlDelegate interface that does nothing. > shouldn't this really do something, such as return an error? Done http://gerrit.cloudera.org:8080/#/c/1403/8/fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java File fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java: Line 68: // Indexes, obtained from the Analyzer's host index, for the set of hosts that will be > i meant: specify the data structure that it indexes into (the exact express Done http://gerrit.cloudera.org:8080/#/c/1403/8/fe/src/main/java/com/cloudera/impala/util/KuduUtil.java File fe/src/main/java/com/cloudera/impala/util/KuduUtil.java: Line 209: * Parses a string of the form "a, b, c" and returns a set of values split by ',' and > update comment. Done. there is, an e2e test in kudu_crud.test, which somehow passed at some point but was failing now. -- To view, visit http://gerrit.cloudera.org:8080/1403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I239314acbc8434ef673a3a59d2a82a0338ea5876 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
