Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2531/3//COMMIT_MSG
Commit Message:

Line 16: schema.
> we really should add some way to test this kind of thing.  is there a way t
Actually, we do have util/parquet-reader.cc, which is a (likely stale) tool for 
outputting a file's metadata and is already part of the Impala build tree. I 
kinda think we should get rid of this file since we don't maintain it, but I 
could probably use it in the test. I'll look into this.


-- 
To view, visit http://gerrit.cloudera.org:8080/2531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-HasComments: Yes

Reply via email to