Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3141: Send full filters when filter production is disabled ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2475/3/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: Line 201: bool IsFull() const { return HasBloomFilter() && bloom_filter_ == NULL; } > Sorry, I'm having some trouble parsing that first sentence - what's the rel i still don't like 'full' because the metaphor only makes sense for a particular implementation of a filter, namely a representation as a bitmap. if we decided to add a second representation, such as an explicit list of partition keys (which may well make sense for sparse key spaces), that wouldn't work anymore. in fact, 'a full filter' to me evokes an image of something that's clogged, ie, won't let anything through. :) maybe there's a better word/concept that expresses 'don't apply this' or 'do apply this'. ('applicable'?) -- To view, visit http://gerrit.cloudera.org:8080/2475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
