Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3141: Send full filters when filter production is disabled ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2475/3/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: Line 201: bool IsFull() const { return HasBloomFilter() && bloom_filter_ == NULL; } > ah, I see - I was thinking from the perspective of a filter being a set (wh hm, if we continue along the 'filter as predicate' axis, then i would prefer 'applicable', or something like it. 'predicate contains every element' sounds contorted. i think we will continue in this direction, because from a planning perspective we need to view filters as predicates (so that we can take their selectivity into account when constructing the operator tree). (and conversely, we could also send an in-predicate as a filter, instead of the bloom filter; we can also represent a gigantic in-list as a FilterPredicate, which would help at least a few -ds or -h queries). -- To view, visit http://gerrit.cloudera.org:8080/2475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b3e6542651c1e7b77a9bab01d0e3d9506af42f Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
