Thomas Tauber-Marshall has submitted this change and it was merged.

Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax
......................................................................


IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax

Added the ability for the "GRANT/REVOKE ALL ON SERVER TO ROLE <role>"
statement to optionally take a server name parameter as:
"GRANT/REVOKE ALL ON SERVER <server> TO ROLE <role>" since Hive
allows this.

The specified server name is checked against the expected server
name from the config during analysis, and an exception is thrown if
they do not match.

Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
Reviewed-on: http://gerrit.cloudera.org:8080/2296
Tested-by: Internal Jenkins
Reviewed-by: Thomas Tauber-Marshall <[email protected]>
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java
M testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test
4 files changed, 60 insertions(+), 11 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/2296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>

Reply via email to