Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax ......................................................................
Patch Set 4: Code-Review+1 (1 comment) I'll let MJ do the final pass. http://gerrit.cloudera.org:8080/#/c/2296/4/testdata/workloads/functional-query/queries/QueryTest/grant_revoke_on_server.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke_on_server.test: Line 1: ==== I don't think you need a separate test file. Also, it seems that many of these test cases already exist in grant_revoke.test. I would recommend expanding the grant_revoke.test with one or two simple tests. Example: grant all on server 'server1' to ...; create db; drop the db; revoke all on server 'server1' from ...; create db; // fail due due to missing permissions -- To view, visit http://gerrit.cloudera.org:8080/2296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
