Alex Behm has posted comments on this change. Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/2296/5/fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java: Line 65: return new PrivilegeSpec(privilegeLevel, TPrivilegeScope.SERVER, null, null, null, return createServerScopedPriv(privilegeLevel, null); Line 173: String serverName = analyzer.getAuthzConfig().getServerName(); call this configServerName or something to make it clear where it comes from Line 176: "match expected server name '%s'", serverName_, serverName)); does not match the configured server name '%s'. (to make it a little more clear where the "expected" server name comes from) http://gerrit.cloudera.org:8080/#/c/2296/5/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: Line 7: create role grant_revoke_test_ALL_SERVER1 move to the end of the file, and add a comment here what we are testing Line 33: ==== please move these new tests to the end of the file -- To view, visit http://gerrit.cloudera.org:8080/2296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
