Dan Hecht has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option ......................................................................
Patch Set 4: (3 comments) That approach to testing looks good to me. Could you also ask someone who's better at python than me to review the test code? http://gerrit.cloudera.org:8080/#/c/2531/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 245: def test_annotate_utf8_option(self, vector): skipif s3 insert Line 264: /test-warehouse/%s/*.parq should use get_fs_path() here. Line 288: maybe also verify that char/varchar converted type is always utf8 regardless of option. -- To view, visit http://gerrit.cloudera.org:8080/2531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
