Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2069: add USE_UTF8_PARQUET_STRINGS query option ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/2531/6/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 246: def test_annotate_utf8_option(self, vector): > shouldn't we add the parquet constraint so we run this just once? This class already has the parquet constraint. It ends up running twice, once with codegen and once without, which is makes no difference for now but seems reasonable enough in an exhaustive build. I can change it if you think it's unnecessary though. Line 271: # Extract SchemaElements corresponding to the two table columns, 'a' and 'b' > Update this comment. Just delete the last part. Done -- To view, visit http://gerrit.cloudera.org:8080/2531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I030c9f5c6272e09c1ce133f66234e3cfb26b68d4 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
