Dan Hecht has posted comments on this change. Change subject: IMPALA-2853: introduce PARQUET_RESOLVE_BY_NAME query option ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/2384/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 2025: if (col_type == NULL) DCHECK_EQ(next_idx, 0); with the new way the code is structured, this might be more intuitive written as: if (next_idx != 0) DCHECK(col_type != NULL); because that's how it looks in the else-if blocks. but up to you. http://gerrit.cloudera.org:8080/#/c/2384/3/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: Line 599: a value >= # how about just simplify: ... or the number of children if not found. http://gerrit.cloudera.org:8080/#/c/2384/3/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 169: 42: optional bool parquet_resolve_by_name = false while i see your point about resolve-by-id needing a fallback, I think this option is going to get confusing once we do add resolve-by-id. will it override resolve-by-id, or override just the fallback, etc? Let's talk in person tomorrow about alternatives to see if we can come up with something that will still be intuitive. http://gerrit.cloudera.org:8080/#/c/2384/3/testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test File testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test: Line 55: '/test-warehouse/nested_resolution_by_name_test_parquet' needs $FILESYSTEM_PREFIX Line 170: ==== any way to test the map key/value logic? http://gerrit.cloudera.org:8080/#/c/2384/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 224: EXECUTE maybe call it 'SHELL' since execute has many meanings? http://gerrit.cloudera.org:8080/#/c/2384/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 240: skip if s3 insert -- To view, visit http://gerrit.cloudera.org:8080/2384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
