Juan Yu has posted comments on this change. Change subject: IMPALA-2853: introduce PARQUET_RESOLVE_BY_NAME query option ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/2384/4/testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test File testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test: Line 22: aaaaaaa','bbbbbbb' : 'ccccc','dddd' : 'eeeeeeee','f' shouldn't the result column 1 and column 2 swap here? or the alter statement doesn't make any difference? Line 28: alter table resolution_by_name_test change a new_a string; do we start a new session for each query test here? If not, the following query will be run with "parquet_resolve_by_name=1", right? (until we reset it back to 0) Line 53: drop table if exists nested_resolution_by_name_test; : create table nested_resolution_by_name_test like complextypestbl would this work if the test is run concurrently in exhaustive mode for various file format? Line 148: rename nested field do we also give warning why impala returns NULL? so user knows what's wrong. -- To view, visit http://gerrit.cloudera.org:8080/2384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
