Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2853: introduce PARQUET_RESOLVE_BY_NAME query option ......................................................................
Patch Set 4: (4 comments) As discussed with Dan, I'm changing the query option to "parquet_fallback_schema_resolution" and the options are "postition" or "name". http://gerrit.cloudera.org:8080/#/c/2384/4/testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test File testdata/workloads/functional-query/queries/QueryTest/parquet-resolution-by-name.test: Line 22: aaaaaaa','bbbbbbb' : 'ccccc','dddd' : 'eeeeeeee','f' > shouldn't the result column 1 and column 2 swap here? It doesn't make a difference if you resolve by name, since we're only changing the order of the columns in the table but the file stays the same. The columns would be swapped if we were resolving by ordinal. Line 28: alter table resolution_by_name_test change a new_a string; > do we start a new session for each query test here? Correct, this is intended. Line 53: drop table if exists nested_resolution_by_name_test; : create table nested_resolution_by_name_test like complextypestbl > would this work if the test is run concurrently in exhaustive mode for vari Hm, probably not, good catch. I changed this test to use the new unique_database fixture (which also required some extra plumbing to pass the database to the test file) Line 148: rename nested field > do we also give warning why impala returns NULL? We don't currently, which I agree is not ideal. We log something at VLOG_FILE but most people have that turned off. It would be easy enough to add a warning to the runtime log. -- To view, visit http://gerrit.cloudera.org:8080/2384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0c715ea23792b2a6872610839a40532aabbb5a6 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
