Jim Apple has posted comments on this change. Change subject: IMPALA-2840: Don't store table location in partition location ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2355/5/fe/src/main/java/com/cloudera/impala/catalog/HdfsPartitionLocationCompressor.java File fe/src/main/java/com/cloudera/impala/catalog/HdfsPartitionLocationCompressor.java: Line 88: public class Location > Not sure I follow. The logic will only be in one place which is the HdfsPar After talking out-of-band, I think I understand. I tried this, but it still leads to less encapsulation, since the Location(thrift ...) constructor and toThrift() devolve to HdfsPartition, and, if we want to store an int and a String, rather than an Integer and a string, we have to repeatedly pack/unpack the Pair. -- To view, visit http://gerrit.cloudera.org:8080/2355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c67b6ce0f83de2f5277a528a9ce67e47d638adb Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
