Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2840: Don't store table location in partition location ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/2355/8/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 43: const impala::THdfsPartition& thrift_partition, std::string* result) { remove std:: http://gerrit.cloudera.org:8080/#/c/2355/8/fe/src/main/java/com/cloudera/impala/util/ListMap.java File fe/src/main/java/com/cloudera/impala/util/ListMap.java: Line 36: private List<T> list_ = Lists.newArrayList(); i think this should be an ArrayList, since we really want get() to be o(1) Line 46: public T getEntry(Integer index) { return list_.get(index); } int index Line 52: public Integer getIndex(T t) { this should return int, not the modifiable recorded index -- To view, visit http://gerrit.cloudera.org:8080/2355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c67b6ce0f83de2f5277a528a9ce67e47d638adb Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
