Jim Apple has posted comments on this change.

Change subject: IMPALA-2840: Don't store table location in partition location
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2355/5/fe/src/main/java/com/cloudera/impala/catalog/HdfsPartitionLocationCompressor.java
File 
fe/src/main/java/com/cloudera/impala/catalog/HdfsPartitionLocationCompressor.java:

Line 88: public class Location
> I am not sure I understand the problem. Are you concerned about the perform
I'm concerned both about the API and the space implications of 
Pair<Integer,String> vs. class P { int i; String s; }


-- 
To view, visit http://gerrit.cloudera.org:8080/2355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c67b6ce0f83de2f5277a528a9ce67e47d638adb
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to