Juan Yu has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE ......................................................................
Patch Set 4: -Code-Review (1 comment) we need to fix the test http://gerrit.cloudera.org:8080/#/c/2580/4/testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test File testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test: Line 137: id > Should this query work or not? I am not sure if this whole test worksl. looks like it's not executed at all. I ran explain this query in Impala-shell and it gives plan correctly. so the fix is fine. just need to fix the test. Also, please note we insert data before change partition format, so all data are written as table format ( text for this one). If you execute this query, it will give error "Invalid RCFILE_VERSION_HEADER". -- To view, visit http://gerrit.cloudera.org:8080/2580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
