Juan Yu has posted comments on this change. Change subject: IMPALA-3194: Allow queries materializing scalar type columns in RC_FILE ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2580/5/testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test File testdata/workloads/functional-planner/queries/PlannerTest/complex-types-file-formats.test: Line 137: # if materializing only scalar type columns. : select id from functional.complextypes_multifileformat t where p = 4 > Do we need this change? This can act as a -ve testcase as well. There is on which test are you talking about? the complextypes_fileformat one? or the one at L112? I think we still need a test for partitioned table. -- To view, visit http://gerrit.cloudera.org:8080/2580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
