Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3194: Allow queries materializing scalar type columns in 
RC_FILE
......................................................................


Patch Set 6:

(1 comment)

Updating the CR as per my discussion with Alex. The latest patch unblock both 
sequence/RC files since they worked prior to 2.3 release. We agreed to deal 
this on a case by case basis rather than opening up for all file formats.

http://gerrit.cloudera.org:8080/#/c/2580/6/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java
File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java:

Line 191:       if (slotDesc.isMaterialized() && 
slotDesc.getType().isComplexType()) {
> This check is not complete because struct fields will have a scalar-typed s
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a89b211bdc01f7e07497e293fafd75ccf0500fe
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-HasComments: Yes

Reply via email to