Dan Hecht has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed ......................................................................
Patch Set 4: > > Too bad about the partial symbols idea. Did you ask Kudu about > > having a function like GetClientVersion() that we could override > in > > our stub to return like -1 or something? > > No I was about to send an email but thought it would be better to > send a non-official request on slack first. I'll wait until more > Kudu people are back. If that did get in, the changes to this patch > would be very minor. Just need to update KuduClientIsAvailable(). What was the issue with getting the weak symbol to work? It should work -- this kind of thing is one of the main reasons they exist. -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
