Matthew Jacobs has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed ......................................................................
Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/2585/5/CMakeLists.txt File CMakeLists.txt: Line 310: DKUDU_CLIENT_SUPPORTED Per your e-mail about the GetVersion() kudu client fn coming in 0.8, can you add a brief comment here and in the commit msg about removing this when we upgrade to 0.8 and can override the stub? Line 317: set(kuduClient_DIR : "$ENV{IMPALA_TOOLCHAIN}/kudu-$ENV{IMPALA_KUDU_VERSION}/share/kuduClient/cmake") I'm confused how this works with the toolchain. Stupid question: will the toolchain build produce this directory structure for both the stub & non-stub cases? Why do we need to point this kuduClient_DIR at it's cmake-- is that just so that find_package below works? -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
