Casey Ching has posted comments on this change. Change subject: Re-enable Kudu in build using client stubs when needed ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/2585/5/CMakeLists.txt File CMakeLists.txt: Line 317: set(kuduClient_DIR : "$ENV{IMPALA_TOOLCHAIN}/kudu-$ENV{IMPALA_KUDU_VERSION}/share/kuduClient/cmake") > I'm confused how this works with the toolchain. Stupid question: will the t The dir will always exist for all os's, the toolchain makes sure of that. That _DIR thing is some cmake magic. If you want to know more there is a bunch of info at https://cmake.org/cmake/help/v3.0/command/find_package.html , it's #2 in the list mid way in the page. http://gerrit.cloudera.org:8080/#/c/2585/5/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: Line 41: return true; > this looks backwards. how are you testing this change? Hmm this got refactored a bit since I tested it. Looks like I messed it up. Thanks! I'm building testing now, held off for a while getting the toolchain stuff straightened out. Line 52: return Status::OK(); > indentation glitch. Done http://gerrit.cloudera.org:8080/#/c/2585/5/tests/custom_cluster/test_kudu_not_available.py File tests/custom_cluster/test_kudu_not_available.py: Line 45: self.assert_failure("SELECT * FROM tinytable", cursor) : self.assert_failure("INSERT INTO tinytable VALUES ('a', 'b')", cursor) : self.assert_failure("DELETE FROM tinytable", cursor) > any reason these don't live in a .test file? I considered it, it just seemed unnecessary. There are only 3 queries and no results now. That could be done later if it would be beneficial. -- To view, visit http://gerrit.cloudera.org:8080/2585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bf1c964faf21722137adc4f7ba7f78654f0f712 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
