Michael Ho has posted comments on this change. Change subject: Upgrade LLVM to 3.8.0 ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/2486/4/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 162: !maybe_file_buffer > maybe_file_buffer == NULL Nevermind. Looks like that's how ErrorOr<T> works. Line 181: !maybe_module > maybe_module == NULL Nevermind. Looks like that's how ErrorOr<T> works. -- To view, visit http://gerrit.cloudera.org:8080/2486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
