Michael Ho has posted comments on this change.

Change subject: Upgrade LLVM to 3.8.0
......................................................................


Patch Set 4:

Btw, have you tried with LLVM assert turned on ? I think it's good to preserve 
the Release+Assert combination for debug builds. This helps catch problem.

FWIW, I tried your patch with ASSERT enabled in LLVM 3.8.0 but it appears to 
trigger an ASSERT in LLVM. Not sure if I may have screwed up on my applying the 
patch or compiling LLVM 3.8.0. I used build.sh in native-toolchain to build 
LLVm 3.8.0.

-- 
To view, visit http://gerrit.cloudera.org:8080/2486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to