Tim Armstrong has posted comments on this change. Change subject: Upgrade LLVM to 3.8.0 ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/2486/4/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 161: maybe_file_buffer > How about tmp_file_buffer ? Done Line 179: maybe_module > How about tmp_module ? Done Line 181: !maybe_module > Nevermind. Looks like that's how ErrorOr<T> works. Yeah it's a little odd. Unfortunately the new LLVM idioms don't quite match our own so the interface code is a little funky. Line 301: module_ = module.get(); > Can you please keep the comment about "execution_engine_ will take ownershi The comment is no longer accurate - the ownership transfer happens earlier with std::move(module). I think it would be redundant (since std::move implies ownership transfer) and we document in the module_ comment that it is owner by execution_engine_. Line 314: if (execution_engine_ == NULL) { > module_ = NULL to avoid stale reference to memory which is about to be free Done -- To view, visit http://gerrit.cloudera.org:8080/2486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d7afd05ad3b472a0bfe035bfc3daada5597b2d Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
