Casey Ching has posted comments on this change. Change subject: Build Kudu from source ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/2679/1/functions.sh File functions.sh: Line 233: build_dist_package 2>&1 | tee -a $BUILD_LOG > Just curious: what's the effect of this change? That it emits to stdout as Yes, without this when something goes wrong you need to do some detective work to even figure out where to look for error messages. If things go well there shouldn't be much noise. http://gerrit.cloudera.org:8080/#/c/2679/1/source/kudu/build.sh File source/kudu/build.sh: Line 31: correspond to a git hash or tag available at https://github.com/cloudera/kudu.git. > Perhaps we should use the Apache git mirror? Technically that is more "upst Change to https://github.com/apache/incubator-kudu is that the one you had in mind? Line 41: # All platforms are "supported". If a parcel is available it will be repackaged, > I thought we're no longer using parcels? I don't understand this 0.7.0 spec Removed the ability to build 0.7. That shouldn't cause a problem since no releases depend on it. Line 110: # Install the binaries. > Yeah, you should also copy the www directory out. Done. In the latest update the debug binaries are built too. Line 112: cp -r bin/* "$LOCAL_INSTALL/bin" > You'll end up with a few non-useful but non-test binaries (e.g. some benchm Updated to remove any binaries that weren't in the parcel. http://gerrit.cloudera.org:8080/#/c/2679/1/source/kudu/repackage_parcel.sh File source/kudu/repackage_parcel.sh: Line 15: > Add a comment up here explaining what this script does and why it's needed? Removed the script instead. -- To view, visit http://gerrit.cloudera.org:8080/2679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
