Adar Dembo has posted comments on this change. Change subject: Build Kudu from source ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2679/3/functions.sh File functions.sh: Line 133: # Usage: header <package name> <package version> [<archive file> You should update this comment with the change you're making. http://gerrit.cloudera.org:8080/#/c/2679/3/source/kudu/build.sh File source/kudu/build.sh: Line 84: incubator-kudu-$KUDU_VERSION incubator-kudu-$KUDU_VERSION "tar xzf" Why do you need to feed in "tar xzf"? Won't header() automatically do the right thing based on the extension of the file? -- To view, visit http://gerrit.cloudera.org:8080/2679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec8494fb4e765ec796b31212c811af34e8514bd Gerrit-PatchSet: 3 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
