Tim Armstrong has posted comments on this change.

Change subject: Add support for Debug and Release+Asserts builds for LLVM 3.7+
......................................................................


Patch Set 1:

I'm going to kick off a private build to check that it works still since the 
patch was a little stale.

I agree that we maybe need to revisit it: I think it's really unclear what the 
interface between the main toolchain scripts and the component scripts is and 
what are valid assumptions when writing component scripts.

-- 
To view, visit http://gerrit.cloudera.org:8080/2658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to