Tim Armstrong has submitted this change and it was merged. Change subject: Add support for Debug and Release+Asserts builds for LLVM 3.7+ ......................................................................
Add support for Debug and Release+Asserts builds for LLVM 3.7+ There was a silent error occurring with applying LLVM patches previously when the source version didn't match the package version. We should report the error if the expected number of patches were not found. As part of the change, get rid of LPACKAGE global variables to give build scripts better control over patch directories. Previously as a convenience, the lower-case package name and version was stored in LPACKAGE and LPACKAGE_VERSION. Instead of this, this patch passes around the lower-case name by default. Also refactor archive extraction into an extract_archive() function that will always use the correct portable extraction method, e.g. untar_xz(). This fixes a bug where we couldn't extract .xz archives pass directly to header() on Centos 4. These builds aren't added to the toolchain yet since we don't plan to use these builds for llvm 3.7 or unpatched llvm 3.8. Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e --- M functions.sh M source/avro/build.sh M source/binutils/build.sh M source/boost/build.sh M source/breakpad/build.sh M source/bzip2/build.sh M source/cmake/build.sh M source/cyrus-sasl/build.sh M source/gcc/build.sh M source/gdb/build.sh M source/gflags/build.sh M source/glog/build.sh M source/googletest/build.sh M source/gperftools/build.sh M source/gtest/build.sh M source/kudu/build.sh M source/libevent/build.sh M source/libunwind/build.sh M source/llvm/build-3.3.sh M source/llvm/build-source-tarball.sh M source/llvm/build-trunk.sh M source/llvm/build.sh M source/lz4/build.sh M source/openldap/build.sh M source/openssl/build.sh M source/python/build.sh M source/rapidjson/build.sh M source/re2/build.sh M source/snappy/build.sh M source/thrift/build.sh M source/zlib/build.sh 31 files changed, 175 insertions(+), 124 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
