Casey Ching has posted comments on this change.

Change subject: Add support for Debug and Release+Asserts builds for LLVM 3.7+
......................................................................


Patch Set 1:

> Just an update on this: I did a test build to check that the new
 > build types were built ok. The debug llvm build is absolutely huge
 > (~8G of artifacts) so the build machines ran out of disk space.
 > This makes me think we should not add the debug build to the
 > toolchain, just the release + asserts build - we can keep the
 > option in to build it locally.

Sounds ok to me. Out of curiosity what was so big?

-- 
To view, visit http://gerrit.cloudera.org:8080/2658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f3430a56428e95e35279838e7b28909d12d10e
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to