Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3276: consistently handle pin failure in 
BTS::PrepareForRead()
......................................................................


Patch Set 1:

No luck reproducing it. I don't think it's actually possible with the analytic 
node since it typically either fails in the downstream sorter and I beleive 
otherwise it should hit "did not have enough memory to get the minimum required 
buffers in the block manager." because it will always be a reserved pin. The 
hash join cases look they we could probably hit them but it would be 
non-deterministic.

-- 
To view, visit http://gerrit.cloudera.org:8080/2684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf1aba50d79b01acdc7269dc23f07b8c19a151a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to