Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3276: consistently handle pin failure in BTS::PrepareForRead() ......................................................................
IMPALA-3276: consistently handle pin failure in BTS::PrepareForRead() BufferedTupleStream::PrepareForRead() can fail in all scenarios except when the stream is all pinned. The basic problem is that reservations in the BufferedBlockMgr are not dependable since they can be overcommitted. This patch changes the interface so that all callers have to handle pin failures and updates the callsites. Change-Id: Iacf1aba50d79b01acdc7269dc23f07b8c19a151a Reviewed-on: http://gerrit.cloudera.org:8080/2684 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/analytic-eval-node.cc M be/src/exec/partitioned-hash-join-node.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/buffered-tuple-stream.cc M be/src/runtime/buffered-tuple-stream.h 5 files changed, 70 insertions(+), 19 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacf1aba50d79b01acdc7269dc23f07b8c19a151a Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
